William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen
......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Sorry to make you confused, the datasheet define the reset delay should equal or longer than 10ms, doesn't contain the typical value.
I saw other project uses the same Goodix IC and the reset delay time were 150ms. As Duncan's suggestion, will change to 120ms and then verify the function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c
Gerrit-Change-Number: 40598
Gerrit-PatchSet: 1
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 Apr 2020 02:23:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment