HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split raminit into desktop and mobile version
......................................................................
Patch Set 19:
Patch Set 19:
Uh, not sure why but it still differs... Does this still boot on the ECS 945G-M4?
- it will boot only if : DIMM0 populated and all the other are not populated.
- it will not boot but it will reach SeaBios if only DIMM1 is populated and all the other not populated.
in current patch , there is nothing done more than we already have in old raminit.c for 945GC.
would you test on the board you have ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I763efcff97ee3d0f1c3df62102f22ee3b3f6a0fc
Gerrit-Change-Number: 39821
Gerrit-PatchSet: 19
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 16:00:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment