Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44709 )
Change subject: soc/mediatek/mt8192: Add dramc 8 phase calibration
......................................................................
Patch Set 49:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44709/48/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44709/48/src/soc/mediatek/mt8192/dr...
PS48, Line 349: d
u
Ack
https://review.coreboot.org/c/coreboot/+/44709/48/src/soc/mediatek/mt8192/in...
File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/44709/48/src/soc/mediatek/mt8192/in...
PS48, Line 37: define
One space (not tab) after "define"
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4ccaa8d43b8382cbc64cf82de86ad1ac16cb89a
Gerrit-Change-Number: 44709
Gerrit-PatchSet: 49
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 25 Dec 2020 07:45:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment