Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33844 )
Change subject: src/security/vboot: Add option to skip display init with vboot 2.0 ......................................................................
Patch Set 7:
I have the feeling that both options, VBOOT_MAY_SKIP_DISPLAY_INIT and VBOOT_MUST_REQUEST_DISPLAY, should be one and named inversely. e.g.
config VBOOT_FORCE_DISPLAY bool "Force display initialization"
which would be selected by all platforms that currently don't select VBOOT_MUST_REQUEST_DISPLAY. This could also obsolete ALWAYS_RUN_OPROM.
I have added Philipp Deppenwiese (document link: https://docs.google.com/document/d/1MB5MaIc9p9yfbe88Ua7Hnb64ra7Y1BomEI4wYYO9...) to the problem statement and solution discussion I had with some other folks on this thread. Please go through it and let me know if there are questions. I couldn't add you since you don't have Google docs account.
If it's not public, I won't read it.
Also, note that once reverted, this will break "all" boards that use vboot but also initialize display in FW as opposed to skipping it.
Would that be different from before this change? If this change regressed something, it doesn't matter what it fixed...
Maybe we can brainstorm about what the fix should look like that will satisfy all use-cases.
If you could start with what this change was supposed to fix, that would help.