Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38475 )
Change subject: mainboard/hatch: Fix puff display on cold boots ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38475/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38475/2//COMMIT_MSG@9 PS2, Line 9: beind behind
https://review.coreboot.org/c/coreboot/+/38475/2//COMMIT_MSG@29 PS2, Line 29: AP does not wait (and firmware screen is displayed on HDMI monitor). What monitors did you test with?
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 42: mdelay(200); 200 ms seems too long for fast boot experience, doesn’t it? 10 ms or 20 ms?
https://review.coreboot.org/c/coreboot/+/38475/2/src/mainboard/google/hatch/... PS2, Line 45: stopwatch_duration_msecs(&sw)); Should fit on one line.