Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38904 )
Change subject: qemu-riscv: Fix discovered DDR size ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38904/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38904/6//COMMIT_MSG@9 PS6, Line 9: qemu-riscv value for DDR is incorrect. It was set to 32768 which that's not true. it was always intended to cover 32GiB.
https://review.coreboot.org/c/coreboot/+/38904/6//COMMIT_MSG@14 PS6, Line 14: based on what you want coreboot to "discover" on boot. it doesn't discover, you are hardcoding values
https://review.coreboot.org/c/coreboot/+/38904/6//COMMIT_MSG@23 PS6, Line 23: chosen from the above items on the qemu cmdline. Please also update the documentation.