Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35998 )
Change subject: mb/lenovo/{x200,t400}: Add VBOOT support
......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/...
File src/mainboard/lenovo/x200/vboot-rwa.fmd:
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/...
PS12, Line 5: SI_ME@0x3000 0x4ed000
/me stumbled and fell into a 64KiB gap
intended?
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/...
PS12, Line 6: }
1MiB gap, intended?
https://review.coreboot.org/c/coreboot/+/35998/12/src/mainboard/lenovo/x200/...
PS12, Line 26:
empty line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I689fe310e5b828f2e68fcbe9afd582f35738ed1d
Gerrit-Change-Number: 35998
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 02 Nov 2019 12:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment