Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37284 )
Change subject: mb/lenovo/t420/devicetree: Use subsystemid inheritance
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37284/1/src/mainboard/lenovo/t420/d...
File src/mainboard/lenovo/t420/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37284/1/src/mainboard/lenovo/t420/d...
PS1, Line 79: device pci 19.0 on end # Intel Gigabit Ethernet
We have an informal style guide that the "end" statements in such single line entries should be alig […]
looks like that isn't documented and linters doesn't complain. marking as invalid until proper documentation and linting exists.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia321f2b974539ac1684173d767dd9eb64060364a
Gerrit-Change-Number: 37284
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 08 Dec 2019 09:37:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment