Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39360 )
Change subject: mb/google/dedede: Add camera support for WDoo ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 37: #if please indent it to left
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 304: PLTRST DEEP
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 306: PLTRST DEEP
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 19: // Method to turn off Power Rails /* Method to turn off Power Rails */
use coreboot comment style, I see it on many places in this file as well as other files in the CL
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 29: // Enable PP2800 lane. /* Enable PP2800 lane */