Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48232 )
Change subject: soc/mediatek/mt8183: Add DRAM_DMA section
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48232/3/src/soc/mediatek/mt8183/mem...
File src/soc/mediatek/mt8183/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/48232/3/src/soc/mediatek/mt8183/mem...
PS3, Line 46: POSTRAM_CBFS_CACHE(0x40100000, 1M)
I'm not sure if 1M is too small for CBFS cache. […]
oh never mind - ignore my comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce9f68883e2787ee7f3c5066f4c47c5ca315633
Gerrit-Change-Number: 48232
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 02:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment