Attention is currently required from: Zheng Bao. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/62750
to review the following change.
Change subject: $(TOP)/Makefile.inc: Handle the folder common before specific one ......................................................................
$(TOP)/Makefile.inc: Handle the folder common before specific one
We can put some common variable in all the subdir Makefile.inc to the common Makefile.inc to reduce the code duplication.
Change-Id: I99597af22cac6d12aaef348789664cd7db02ba06 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/62750/1
diff --git a/Makefile.inc b/Makefile.inc index ec2d097..83607a2 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -81,7 +81,8 @@ # root source directories of coreboot subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi src/superio/common subdirs-y += src/ec/acpi $(wildcard src/ec/*/*) $(wildcard src/southbridge/*/*) -subdirs-y += $(wildcard src/soc/*) $(wildcard src/soc/*/*) $(wildcard src/northbridge/*/*) +subdirs-y += $(wildcard src/soc/*) $(wildcard src/soc/*/common) $(wildcard src/soc/*/*) +subdirs-y += $(wildcard src/northbridge/*/*) subdirs-y += $(wildcard src/superio/*) $(wildcard src/superio/*/*) subdirs-y += $(wildcard src/drivers/*) $(wildcard src/drivers/*/*) $(wildcard src/drivers/*/*/*) subdirs-y += src/cpu src/vendorcode