build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: soc/amd/picasso: add dptc support ......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43408/19/src/soc/amd/picasso/root_c... File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/43408/19/src/soc/amd/picasso/root_c... PS19, Line 36: #define DPTC_INPUTS(_sustained, _fast, _slow) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/43408/19/src/soc/amd/picasso/root_c... PS19, Line 202: config->sustained_power_limit_tablet_mode, line over 96 characters
https://review.coreboot.org/c/coreboot/+/43408/19/src/soc/amd/picasso/root_c... PS19, Line 214: dptc_call_alib("TABB", (uint8_t *)(void *)&tablet_mode_input, sizeof(tablet_mode_input)); line over 96 characters