Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Rampayload: Able to build coreboot without ramstage
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/33142/7/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33142/7/src/Kconfig@1195
PS7, Line 1195: config ENABLE_STAGE_BOOTBLOCK
It would be nice to align the naming with the already established
HAVE_* pattern in coreboot. e.g. HAVE_BOOTBLOCK, HAVE_VERSTAGE,
etc.
https://review.coreboot.org/#/c/33142/7/src/Kconfig@1199
PS7, Line 1199: This option is enabled to select bootblock architecture.
I don't understand what `architecture` refers to here? Maybe
this doesn't need a help text at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f7e4174619016c5a54c28bedd52699df417a5b7
Gerrit-Change-Number: 33142
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Jun 2019 11:10:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment