Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
But placing selects in `Kconfig.name` is already common practice for a year or so or maybe more.
I started doing it back in mid-2018 when I folded all the Skylake ChromeOS boards into variants of google/glados. I don't recall any objections at the time 😊
Are you 100% sure it will only be the SoC?
unless the ODM is lying, yes, as they claim the schematics are unchanged. I have both boards here, and in theory the only differences firmware-wise should be SoC (FSP), microcode, and VGA PCI ID. The devicetrees and GPIO defs should be the same, but aren't currently, and that's something I need to reconcile before it's ready to merge