18 Jun
2019
18 Jun
'19
11:33 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33431 )
Change subject: TEMP: NOT FOR REVIEW: google/mistral: Add LED calibration ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... File src/mainboard/google/mistral/led_calibration.c:
https://review.coreboot.org/#/c/33431/3/src/mainboard/google/mistral/led_cal... PS3, Line 53: _strspn
Renamed and moved them. […]
oops, string.c isn't built for verstage, but adding it to the Makefile.inc works sure enough.
Maybe consider splitting this into a separate commit, too?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff3ab55cdd12a8e8fe7549bce99a88ed0ef01534
Gerrit-Change-Number: 33431
Gerrit-PatchSet: 4
Gerrit-Owner: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yuji Sasaki sasakiy@chromium.org
Gerrit-Reviewer: Zhihong Yu zhihongyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yuji Sasaki sasakiy@chromium.org
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment