Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30873 )
Change subject: [RFC] cpu/intel/car: Use symbols for CAR MTRR setup
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30873/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/30873/4/src/soc/intel/common/block/...
PS4, Line 109: #if 0
Do we need two MTRRs? Don't we get the same cacheline utilisation by limiting the load to _car_mtrr_size below.
Probably not, as long as the CAR region with cachelines utilized is large enough to fit the programs. Unless FSP-M is supposed to be independent of FSP-T so I would guess that it does not care about how CAR is set up as long as it's in the right place?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30873
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32d7337ccf8005c7fb65d2efea40c122093d4dd9
Gerrit-Change-Number: 30873
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 08 Nov 2019 10:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment