V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43791 )
Change subject: soc/intel/jasperlake: Add FSP UPD for minimum assertion widths
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43791/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43791/4//COMMIT_MSG@9
PS4, Line 9: Add the FSP UPD for the chipset minimum assertion width
nit: Add the FSP UPDs for the PchPmPwrCycDur dependent sleep signal assertion widths
Since we are adding PchPmSlpSusMinAssert also here which is not PchPmPwrCycDur dependent sleep signal, i will retain as it is here.
https://review.coreboot.org/c/coreboot/+/43791/1/src/soc/intel/jasperlake/ch...
File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/43791/1/src/soc/intel/jasperlake/ch...
PS1, Line 344: * - PM_CFG.SLP_LAN_MIN_ASST_WDTH
Could you elaborate on this question?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I042e8e34b7dfda3bc21e5f2e6727cb7692ffc7f7
Gerrit-Change-Number: 43791
Gerrit-PatchSet: 5
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Aug 2020 16:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya
v.sowmya@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment