Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h>
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h
File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h@6
PS4, Line 6: /* When <device/pnp.h> is needed, it supposed to provide <device/pnp_{def,type}.h> */
move the change of this line in the patch before?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e479e2abdb6cfb8633840db2222ce5397fe7d55
Gerrit-Change-Number: 45403
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 16:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment