Attention is currently required from: Martin L Roth, Paul Menzel, Angel Pons, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62827 )
Change subject: lib/cbfs: Compare addresses instead of arrays
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
There only seems to be one occurrence in coreboot, so just let’s fix it, and keep the warning enabled.
Even with one occurrence, I think Julius's comment is still valid.
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/62827/comment/4b186758_04c08843
PS1, Line 31: _preram_cbfs_cache
Where is this defined?
Created from linker script symbols in include/memlayout.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69310b0bec166faa40f56a36c6d360065cf6b08a
Gerrit-Change-Number: 62827
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-Attention: Martin L Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 08:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment