Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38755 )
Change subject: nb/amd/{agesa,pi}/acpi: include thermal zone
......................................................................
Patch Set 1: Code-Review+1
I can confirm the register compatibility. But... reading thermal_mixin.asl,
that code doesn't seem to make much sense. The ThermalZone is only reported
as present if HTC (hardware temperature control) is enable, so far so good.
But then the limit that would trigger HTC is used as _CRT (immediate shut-
down) and (-10K) as _HOT (better power down now). Unless the HTC limit
register is configured very wrong, this would force the OS to shut down
rather early.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbdf44508085964452d74e084b133f1baa39e1a8
Gerrit-Change-Number: 38755
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 16 Feb 2020 13:44:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment