Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36524 )
Change subject: mb/google/drallion: Update GPIO table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/36524/1/src/mainboard/google/dralli...
PS1, Line 47: /* ISH_GP3 */ PAD_NC(GPP_A21, NONE), /* ISH_NB_MODE */
I think if we set NC, ISH can control this pin. So, yes. […]
Okay according to Tim.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36524
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee61c74a5cab5a62a90c0543f212650c4f2420de
Gerrit-Change-Number: 36524
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment