build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34983 )
Change subject: WIP: add src/ec/hp/it8987e ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.h File src/ec/hp/it8987e/ec.h:
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.h@25 PS1, Line 25: #define EC_IO_HIGH EC_IO + 1 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.h@26 PS1, Line 26: #define EC_IO_LOW EC_IO + 2 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.h@27 PS1, Line 27: #define EC_IO_DATA EC_IO + 3 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c File src/ec/hp/it8987e/ec.c:
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@74 PS1, Line 74: if (!output_buffer_full(KBD_STATUS)) return 0; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@80 PS1, Line 80: if (!input_buffer_empty(KBD_STATUS)) return; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@86 PS1, Line 86: if (!input_buffer_empty(KBD_STATUS)) return; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@97 PS1, Line 97: if (!output_buffer_full(EC_SC)) return 0; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@103 PS1, Line 103: if (!input_buffer_empty(EC_SC)) return; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/34983/1/src/ec/hp/it8987e/ec.c@109 PS1, Line 109: if (!input_buffer_empty(EC_SC)) return; trailing statements should be on next line