[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/nissa/var/uldren: Modify DPTF parameters

[Paul Menzel (Code Review)]

Attention is currently required from: Dtrain Hsu, Shou-Chieh Hsu, Tarun Tuli.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76105?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/nissa/var/uldren: Modify DPTF parameters
......................................................................

Patch Set 1:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76105/comment/f60611b7_9dd0a25a :
PS1, Line 7: Modify
That’s too broad. Please use a more specific verb.

https://review.coreboot.org/c/coreboot/+/76105/comment/f5e2a032_e6d086b3 :
PS1, Line 11: 
Please list/enumerate the changes.

https://review.coreboot.org/c/coreboot/+/76105/comment/957bc1d2_61baee36 :
PS1, Line 14: TEST=emerge-nissa coreboot chromeos-bootimage
Don’t you need to boot it also and run some tests?

File src/mainboard/google/brya/variants/uldren/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76105/comment/45c443b1_80605235 :
PS1, Line 109: 	register "tcc_offset" = "3"
Please add a comment what value that actually results in.