Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39999 )
Change subject: soc/amd/common/psp: Consolidate FW blob load functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps... File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/39999/1/src/soc/amd/common/block/ps... PS1, Line 312: (type == BLOB_SMU_FW || type == BLOB_SMU_FW2)
hm, maybe i do fix this here, since this is newly introduced in this patch, so that change should be […]
It's been a while since I've considered this, however I'd likely done it intentionally to cover the possibility that there could be future loadable blob types. However I agree it's redundant as the source sits. The switch above would be used to weed out all non-understood blobs. For SMU_FW & FW2, there's the additional requirement that the feature must be built into the BIOS.
In reality, I don't currently foresee any new loadable blobs in the future. So I'd be OK with removing the redundancy and adding a comment instead.