Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, cong yang, ot_hao.han@mediatek.com.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email )
Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/geralt/panel.c:
https://review.coreboot.org/c/coreboot/+/78957/comment/0001a9f2_b23dc9e6 :
PS11, Line 72: mdelay(10);
This delay is not needed for i2c and should be required by the panel.
We can move `mtk_i2c_bus_init` to the beginning to make power-on sequences more clear.
```
mtk_i2c_bus_init(cfg->i2c_bus, I2C_SPEED_FAST);
/* Enable VM18V */
mainboard_enable_regulator(MTK_REGULATOR_VDD18, true);
mdelay(1);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78957?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9
Gerrit-Change-Number: 78957
Gerrit-PatchSet: 11
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: ot_hao.han@mediatek.com
ot_hao.han@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: ot_hao.han@mediatek.com
ot_hao.han@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 07:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: ot_hao.han@mediatek.com
ot_hao.han@mediatek.corp-partner.google.com
Gerrit-MessageType: comment