Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55046 )
Change subject: arch/x86/bootblock.ld: Align the bottom of the bootblock to 64 bytes
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55046/comment/ed447e4f_f788cdb7
PS1, Line 11: - Bootguard/CBnT requires a 64 byte alignment
I thought reading comments once that Bootquard needed fixed bootblock size?
I was not correct. The open source Btg/CBnT tooling was quite crude then. The tooling improved and is now coreboot/cbfs aware and can detect bootblock automatically.
https://review.coreboot.org/c/coreboot/+/55046/comment/f370995a_4e072035
PS1, Line 12: - It can reduce the bootblock footprint as the size is aligned upwards
Is potential of 48 bytes saved worth mentioning?
Not really.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55046
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69cdacdd15bfca1b91b6f271f2ff76889969fd91
Gerrit-Change-Number: 55046
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 28 May 2021 13:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment