Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean up report_cpu_info() function
......................................................................
Patch Set 4:
(3 comments)
Does the commit message match the actual diff?
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@9
PS4, Line 9: clean up
clean-up
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@14
PS4, Line 14:
It could be three commits next time?
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@15
PS4, Line 15: TEST=Able to build and boot soraka.
seems to needlessly clutter the commit message
Isn’t a successful boot is worth mentioning?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf7b04edc3fce147f7856591ce7e5a0cd05f43fe
Gerrit-Change-Number: 36840
Gerrit-PatchSet: 4
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 11:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment