[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp/cpx: display SystemMemoryMapHob fields

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43336 )

Change subject: soc/intel/xeon_sp/cpx: display SystemMemoryMapHob fields
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43336/4/src/soc/intel/xeon_sp/cpx/h... 
File src/soc/intel/xeon_sp/cpx/hob_display.c:

https://review.coreboot.org/c/coreboot/+/43336/4/src/soc/intel/xeon_sp/cpx/h... 
PS4, Line 188: 		soc_display_memmap_hob((const struct SystemMemoryMapHob **)(guid + 16));
> So this wasn't working properly before?

We had thought what is stored in the HOB structure (following 16 bytes of GUID) is the HOB data. Intel clarified that what is stored in the HOB structure is actually a 8 byte address pointing to the HOB data.