Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 4:
(4 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203): https://review.coreboot.org/c/coreboot/+/58899/comment/59ebac5e_c372d984 PS4, Line 108: #define DECLARE_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203): https://review.coreboot.org/c/coreboot/+/58899/comment/e3c5ebf5_0a21d10b PS4, Line 109: const struct cros_gpio *variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203): https://review.coreboot.org/c/coreboot/+/58899/comment/bbf8e039_e1f2c3f9 PS4, Line 115: #define DECLARE_WEAK_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203): https://review.coreboot.org/c/coreboot/+/58899/comment/3525fae5_9a371e7a PS4, Line 116: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \ please, no space before tabs