Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.

View Change

4 comments:

• File src/vendorcode/google/chromeos/chromeos.h:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203):

    Patch Set #4, Line 108: #define DECLARE_CROS_GPIOS(x) \

    Macros with flow control statements should be avoided

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203):

    Patch Set #4, Line 109: const struct cros_gpio *variant_cros_gpios(size_t *num) \

    please, no space before tabs

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203):

    Patch Set #4, Line 115: #define DECLARE_WEAK_CROS_GPIOS(x) \

    Macros with flow control statements should be avoided

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132203):

    Patch Set #4, Line 116: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \

    please, no space before tabs

To view, visit change 58899. To unsubscribe, or for help writing mail filters, visit settings.