Attention is currently required from: Daisuke Nojiri, Caveh Jalali.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73217 )
Change subject: mb/brya/variant/bb/{brya,hades}/include/ec: Add EC_HOST_EVENT_GPU
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/73217/comment/15d7f808_e58e9525
PS8, Line 19: EC_HOST_EVENT_GPU
we should add a Kconfig for this event (or dGPU in general) […]
What is the thinking of excluding this mask on some variants? Would we potentially reuse the same bit for different purposes on different variants in the future?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d7bf52efa9572e1bbd2f307420e09a7398a1ca9
Gerrit-Change-Number: 73217
Gerrit-PatchSet: 8
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Comment-Date: Fri, 03 Mar 2023 19:42:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment