Nico Huber has posted comments on this change. ( https://review.coreboot.org/27927 )
Change subject: mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/27927/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@7 PS1, Line 7: .cb no suffix needed
https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@7 PS1, Line 7: misleading comments they are not supposed to be comments. maybe rather `Remove spurious CPP directives`.
https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@9 PS1, Line 9: The devicetree is not run through a C pre-processor, so remove it. Hmmmm, I guess the extra chip entries do matter for I2C. Because that bus isn't probed... I guess the drivers add spurious ACPI code currently. That should be fixed if it's the case.