Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 97:
(12 comments)
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Kconfig:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 42: DDR4 nit: space after #
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 6: ramstage-y += mainboard.c not needed, included in src/arch/x86/Makefile.inc
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 8: ramstage-y += hda_verb.c not needed, included in src/device/Makefile.inc
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 2: ## This file is part of the coreboot project. this line can be dropped in all files (see CB:41194)
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 6: # Disable deep Sx states : register "deep_s3_enable_ac" = "0" : register "deep_s3_enable_dc" = "0" : register "deep_s5_enable_ac" = "0" : register "deep_s5_enable_dc" = "0" : register "deep_sx_config" = "DSX_EN_WAKE_PIN" can be dropped when disabled
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 26: Enable
um, forgot to put an emoji, I'm not angry about this 😄
well, this can be completely dropped, assuming dptf shall be disabled
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 31: register "ScsEmmcEnabled" = "0" : register "ScsEmmcHs400Enabled" = "0" : register "ScsSdCardEnabled" = "0" : register "HeciEnabled" = "0" : register "SkipExtGfxScan" = "0" can be dropped
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 39: register "PmTimerDisabled" = "0" duplicate; =0 can be dropped anyways
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 41: register "DspEnable" = "0" can be dropped
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 70: register "PmTimerDisabled" = "0" duplicate; =0 can be dropped anyways
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 106: 0, : [5] = 0, : [6] = 0, : [7] = 0, can be dropped
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/ramstage.c:
https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 13: CdClock not sure if that is still needed; default is "Auto"; Maybe test and drop