12 comments:
File src/mainboard/asus/h110m-e_m2/Kconfig:
nit: space after #
File src/mainboard/asus/h110m-e_m2/Makefile.inc:
Patch Set #97, Line 6: ramstage-y += mainboard.c
not needed, included in src/arch/x86/Makefile.inc
Patch Set #97, Line 8: ramstage-y += hda_verb.c
not needed, included in src/device/Makefile.inc
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
Patch Set #97, Line 2: ## This file is part of the coreboot project.
this line can be dropped in all files (see CB:41194)
# Disable deep Sx states
register "deep_s3_enable_ac" = "0"
register "deep_s3_enable_dc" = "0"
register "deep_s5_enable_ac" = "0"
register "deep_s5_enable_dc" = "0"
register "deep_sx_config" = "DSX_EN_WAKE_PIN"
can be dropped when disabled
Patch Set #97, Line 26: Enable
um, forgot to put an emoji, I'm not angry about this 😄
well, this can be completely dropped, assuming dptf shall be disabled
register "ScsEmmcEnabled" = "0"
register "ScsEmmcHs400Enabled" = "0"
register "ScsSdCardEnabled" = "0"
register "HeciEnabled" = "0"
register "SkipExtGfxScan" = "0"
can be dropped
Patch Set #97, Line 39: register "PmTimerDisabled" = "0"
duplicate; =0 can be dropped anyways
Patch Set #97, Line 41: register "DspEnable" = "0"
can be dropped
Patch Set #97, Line 70: register "PmTimerDisabled" = "0"
duplicate; =0 can be dropped anyways
0,
[5] = 0,
[6] = 0,
[7] = 0,
can be dropped
File src/mainboard/asus/h110m-e_m2/ramstage.c:
Patch Set #97, Line 13: CdClock
not sure if that is still needed; default is "Auto"; Maybe test and drop
To view, visit change 34603. To unsubscribe, or for help writing mail filters, visit settings.