Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38776 )
Change subject: mb/google/dedede: Add console UART configuration
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38776/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38776/3/src/mainboard/google/dedede...
PS3, Line 94: on
Note: If function 0 of a PCI device is disabled, then all the higher functions become disabled too. […]
nvm. I see that it is done in follow-up patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30a64a3c96226ce3244d55919b6d65fbf0a096e2
Gerrit-Change-Number: 38776
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 00:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment