[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support

[Nick Chen (Code Review)]

Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )

Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................

Patch Set 16:

(4 comments)

https://review.coreboot.org/c/coreboot/+/44632/12/src/mainboard/google/volte... 
File src/mainboard/google/volteer/variants/eldrid/gpio.c:

https://review.coreboot.org/c/coreboot/+/44632/12/src/mainboard/google/volte... 
PS12, Line 192:         /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
> code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/44632/12/src/mainboard/google/volte... 
PS12, Line 193:         PAD_CFG_GPO(GPP_D16, 1, DEEP),
> code indent should use tabs where possible

Done

https://review.coreboot.org/c/coreboot/+/44632/12/src/mainboard/google/volte... 
PS12, Line 193:         PAD_CFG_GPO(GPP_D16, 1, DEEP),
> please, no spaces at the start of a line

Done

https://review.coreboot.org/c/coreboot/+/44632/6/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/eldrid/memory.c:

https://review.coreboot.org/c/coreboot/+/44632/6/src/mainboard/google/voltee... 
PS6, Line 7: /*This mb_ddr4_cfg structure is intentionally left empty so that fields are left nil. 0 on the UPD means let MRC auto configure. e do not need to set any Rcomp values, MRC will auto configure them.*/
> line over 96 characters

Done