Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38276 )
Change subject: gma bxt panel: Allow to use secondary panel control logic
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38276/1/common/hw-gfx-gma-panel.a...
File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/38276/1/common/hw-gfx-gma-panel.a...
PS1, Line 202: Static_Init;
Hmmm?
It's removed in the inner procedure but called once before the loop? line 324 RHS
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/38276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Ie84d21a07a0f064f993a54b277e051b8d1ca541c
Gerrit-Change-Number: 38276
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sat, 15 Feb 2020 15:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment