2 Jul
2019
2 Jul
'19
2:36 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a ......................................................................
Patch Set 6: Code-Review+1
looks good to me. I'll wait with +2ing and merging until there's a patch using the SIO support added in this patch. Without a board using a SIO, the SIO code doesn't get build tested. Poke me again when the board code is on Gerrit and buildbot is happy with that patch and I'll get this patch merged.
Oh and I have to say that I prefer the current state of the fan control API added in this patch over the devicetree-based one used by other SIO/EC :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/33623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d336e76bccc38452b1b1aefef5d4a4f7ee129a8
Gerrit-Change-Number: 33623
Gerrit-PatchSet: 6
Gerrit-Owner: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Charles Marslett charles.marslett@silverbackltd.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 12:36:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment