[coreboot-gerrit] Change in coreboot[master]: src/lib: Add Kconfig option for SPD cache in FMAP

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48520 )

Change subject: src/lib: Add Kconfig option for SPD cache in FMAP
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/48520/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48520/1//COMMIT_MSG@9 
PS1, Line 9: sodimm
nit: I'd say `DIMM` instead

https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig 
File src/lib/Kconfig:

https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@57 
PS1, Line 57: _IN_FMAP
> It's a minor nit since it felt redundant. I am okay if you want to go ahead with this name.

I wouldn't use SODIMM in the option name. After all, it would work just fine with desktop-size DIMMs, wouldn't it? 😊

https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@61 
PS1, Line 61: SODIMM
nit: DIMM