Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45868 )
Change subject: soc/intel/xeon_sp: Set CPU_ADDR_BITS to 46 for SKX and CPX
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45868/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45868/1//COMMIT_MSG@9
PS1, Line 9: According to document number 338846 this should be set to 46 bits.
Please check SKX-SP doc as well. The default also does not apply to SKX-SP.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bbe6c962ffc7d5dc722f1cacf55bc0d0615db59
Gerrit-Change-Number: 45868
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 12:50:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment