build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... PS10, Line 170: InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *) MemoryTable_XM_E; line over 96 characters
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... PS10, Line 165: //#define BLDCFG_VRM_NB_SLEW_RATE 5000 // Used in calculating the VSRampSlamTime line over 96 characters
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... PS10, Line 97: printk(BIOS_INFO, "%s done.\n", __func__,); space required after that ',' (ctx:VxB)
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/mptable.c:
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... PS10, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/30987/10/src/mainboard/asus/a88xm-e... PS10, Line 111: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(int_sign)), ioapic_id, (pin)) line over 96 characters