Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45400 )
Change subject: soc/mediatek/mt8192: add pmic MT6315 driver
......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45400/24/src/soc/mediatek/mt8192/mt...
File src/soc/mediatek/mt8192/mt6315.c:
https://review.coreboot.org/c/coreboot/+/45400/24/src/soc/mediatek/mt8192/mt...
PS24, Line 240: {
Check
if (!pmif_arb)
die("ERROR: pmif_arb not initialized");
Same for mt6315_buck_get_voltage().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b47473ee5d56a197bd21d4ab9b539d9663b6636
Gerrit-Change-Number: 45400
Gerrit-PatchSet: 24
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 10 Nov 2020 03:58:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment