Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19023 )
Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skyk... File src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h:
PS3, Line 66: } Bits; : UINT32 Uint32[2]; : } CPU_CONFIG_FSP_DATA; why added space? don't we run clean up script?
https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skyk... File src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h:
PS3, Line 41: #include <MemInfoHob.h> directory structure change ??