Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/27808 )
Change subject: mb/google/poppy/variants/rammus: add rammus devicetree.cb ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/devicetree.cb:
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... PS1, Line 47: 2
0?
Rammus will use SOC SDIO, so we need to enable this.
https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/... PS1, Line 82: #| IccMax | 4A | 28A | 24A | 24A |
This is already being set here: https://review.coreboot. […]
Thanks for point it out. i will remove the IccMax setting.