Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )
Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................
Patch Set 10:
(4 comments)
File src/soc/mediatek/mt8196/ddp.c:
https://review.coreboot.org/c/coreboot/+/85950/comment/fd03a0fc_265ee63a?usp... :
PS9, Line 267: BIT(28) | BIT(31));
exceed 96 characters
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/3ed741d2_7cb841b8?usp... :
PS9, Line 291: d
%u
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/db1f50bb_2abf553a?usp... :
PS9, Line 301: d
%u
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/286ee641_bf4aded6?usp... :
PS9, Line 306: %d/%d exceed hw limit %d\
use %u
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466
Gerrit-Change-Number: 85950
Gerrit-PatchSet: 10
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 13:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com