Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42196 )
Change subject: assert.h: Do not use __FILE__ nor __LINE__ on timeless builds
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42196/2/src/include/assert.h
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/42196/2/src/include/assert.h@17
PS2, Line 17: #line 404 "(filenames not available on timeless builds)"
So does this actually work? From my understanding of what the #line directive does, it shouldn't... […]
Right, this won't work. I'll roll back to the previous approach
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id42d7121b6864759c042f8e4e438ee77a8ac0b41
Gerrit-Change-Number: 42196
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 20 Jun 2020 11:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment