build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 34:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 111: PCI_FUNCTION_NUMBER_QNC_LPC); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 111: PCI_FUNCTION_NUMBER_QNC_LPC); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 112: return (uint16_t) pci_read_config32(dev, R_QNC_LPC_PM1BLK) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 112: return (uint16_t) pci_read_config32(dev, R_QNC_LPC_PM1BLK) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 113: & B_QNC_LPC_PM1BLK_MASK; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/33234/34/src/soc/intel/quark/acpi.c... PS34, Line 113: & B_QNC_LPC_PM1BLK_MASK; please, no spaces at the start of a line