24 Jul
2020
24 Jul
'20
4:24 p.m.
Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39581 )
Change subject: src/soc/intel/jasperlake: Update SD card ACPI device ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 95: If (LEqual (Arg0, DSUU)) {
Please use ASL 2.0 syntax.
Just to confirm, that would be If (Arg0 == DSUU) {?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f944caa535bdc946eef1e0f518fe3ee344187b9
Gerrit-Change-Number: 39581
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment