[coreboot-gerrit] Change in ...coreboot[master]: soc/intel: Fix for missing mem_rank info in SMBIOS

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )

Change subject: soc/intel: Fix for missing mem_rank info in SMBIOS
......................................................................

Patch Set 10:

(3 comments)

The submodule pointer change needs to be removed.

https://review.coreboot.org/#/c/31235/10//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31235/10//COMMIT_MSG@7 
PS10, Line 7: soc/intel: Fix for missing mem_rank info in SMBIOS
Please make it a statement by using a verb (in imperative mood):
> Fix missing mem_rank info in SMBIOS

Maybe better:
> Add mem_rank info to SMBIOS

https://review.coreboot.org/#/c/31235/10//COMMIT_MSG@11 
PS10, Line 11: BUG=b:122329046
Please add a blank line above.

https://review.coreboot.org/#/c/31235/10//COMMIT_MSG@12 
PS10, Line 12: TEST=Boot to OS
… and run `dmidecode`?

On what board (are there variants)?