Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37840/4//COMMIT_MSG@8 PS4, Line 8:
What are you cleaning up?
Good question. Primarily:
- Use lowercase for the letters of hex constants e.g.: 0xDEADBEEF --> 0xdeadbeef - Use C-style comments everywhere - Use denary (decimal) for length values
I also felt that some comments were not informative enough to keep, so I dropped them. The most painful comments are those with the same hex constant used in the code right below.
As to why I did this... I felt like it ¯_(ツ)_/¯
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 22: 13,
since this is a quad-byte word like all the rest of the verb data, seems odd to change format here, […]
Nico told me to use decimal for these values instead of hex in CB:37483
https://review.coreboot.org/c/coreboot/+/37840/3/src/mainboard/google/auron/... PS3, Line 49: 0x01471c10, /* group 1, cap 0 */ : 0x01471d01, /* no connector, no jack detect */ : 0x01471e17, /* speaker out, analog */ : 0x01471f90, /* fixed function, internal, Location N/A */
probably easier just to convert to the azalia macros and then have a single comment block, no?
Indeed. Should I do it on a separate change?